search

isDipesh / gnome-shell-extension-sensors

Gnome shell extension: Shows CPU temperature, HDD temperature, voltage and fan RPM
https://motorscript.com/gnome-shell-extension-sensors/
161 stars 153 forks source link

Possible Memory Leak #85

Closed hmaarrfk closed 10 years ago

hmaarrfk commented 11 years ago

I think you have a memory leak either in the plugin or lm_sensors has a leak on it's own.

After a few hours, the memory footprint of gnome-shell grows to 600 MB compared to ~250 MB without the plugin.

My configuration: F19 x64 lm_sensors installed Intel processors i5 3rd gen no external graphics cards Gnome Shell 3.8.2

adrianbroher commented 11 years ago

Hello hmaarrfk,

I will try to confirm this. However, if the extension is causing memory leaks I don't really know how to fix this. I would assume the gjs would take care of that becaus as far as I know there is no way to do memory management in JavaScript (and there shouldn't be because the JS implementation should handle it).

hmaarrfk commented 11 years ago

FYI, Seems like it it might not be your plugin causing the leak, just making it easier to reproduce.

https://bugzilla.redhat.com/show_bug.cgi?id=977387

Gnome Shell isn't the same without your temperature indicator :(

adrianbroher commented 10 years ago

Starting with commit c55df0e499cf73530c68a73ba8ca27b92b912006 this issue should be fixed. I had running a gnome-shell for serveral days with only the sensors extension enabled and I couldn't see any significant change in memory consumption.

If you still have a problem with a memory leak feel free to reopen this issue.

Rmano commented 10 years ago

Hi --- has this change pushed to extension.gnome.org? I have still a very big leak and the files in the extension folder have dates around May 2013... uninstalling and reinstalling gives the same result. I have ubuntu 13.10, with shell 3.8, maybe this is the reason. If I compile myself the extension for 3.8, will this one has the bug fix in?