isXander / Controlify

Another controller mod - for fabric!
https://www.isxander.dev/mods/controlify
GNU Lesser General Public License v3.0
143 stars 31 forks source link

[Bug] 2.0.0 Vibration setting changes #263

Closed aekramer closed 5 months ago

aekramer commented 6 months ago

Current Behaviour

Since the V2 settings for changing vibrations have changed significantly, and I believe some are not under the right category, for example zooming in using a Spyglass falls under "Effects that are specific to the player" while I find that it would fit under Interaction "using items" much better.

Expected Behaviour

We should be given much more flexibility in selecting when and where vibrations should occur, for example (from what I can recall on top of my head), this is the perfect behaviour pattern in my eyes:

Vibrations ON:

Vibrations OFF:

Personally I would turn it off for nearly everything besides taking damage, but I can see why people may want it for breaking blocks/eating food, but while using a bow or spyglass its a bit annoying

Screenshots

No response

Reproduction Steps

Go to settings menu > Vibrations and compare version 1.8 vs 2.0 of the mod

Logs

No response

Mod Version

2.0 + 1.20.4

Controller

Xbox One S Controller

Bluetooth

Operating System

Windows

ARM

Additional Information

No response

Just to make sure...

aekramer commented 5 months ago

In addition: Disabling "Allow vibration" entirely still vibrates controls when using something like spyglass/bow

isXander commented 5 months ago

Looks like I forgot to make the allow vibration toggle do anything at all!