isXander / CullLessLeaves

Cull leaves while looking hot!
GNU Lesser General Public License v3.0
38 stars 15 forks source link

[Bug] Crash on startup with 1.3.0 #56

Closed IntMarco closed 1 year ago

IntMarco commented 1 year ago

https://mclo.gs/KEvRAZN

IntMarco commented 1 year ago

The crash is not caused by Sodium but by Memory Leak Fix.

Zorklis commented 1 year ago

Thanks for tracking down the incompatibility, I'm experiencing the same one, don't recall this occuring on the previous version of CullLessLeaves

IntMarco commented 1 year ago

It happends only with the latest version. (1.3.0)

pingouyn commented 1 year ago

Confirming CullLessLeaves 1.3.0 crashes with Sodium 0.5.2 and Memory Leak Fix 1.1.1. Solved by removing Memory Leak Fix (not ideal). latest.log https://ufile.io/w7yhb86o

As CullLessLeaves is inspired from / based on CullLeaves, it's worth pointing out there was a similar issue with mod CullLeaves 3.1.0 not being compatible with sodium 0.5.2; this was resolved somehow in their 3.2.0 release. I do not know if there was also an incompatibility with Memory Leak Fix. Just a thought, maybe it's worth checking how CullLeaves solved their incompatibility issue. PS: I do not have the knowledge to do this myself, sorry.

isXander commented 1 year ago

All I did is bumped mixin extras. Memory Leak Fix probably needs to do the same and stop messing with mixin plugins.

IntMarco commented 1 year ago

I closed this report because the issue is caused by Memory Leak Fix and not by Cull Less Leaves.