[Patch Request] MC-73186 (Model Gap Fix)

isXander / Debugify

A mod aimed at fixing bugs found on the Mojang Bug Tracker

GNU Lesser General Public License v3.0

189 stars 42 forks source link

[Patch Request] MC-73186 (Model Gap Fix) #82

Open RaptaG opened 2 years ago

RaptaG commented 2 years ago

Mojang Bug Report ID

MC-73186

Mod Loader

N/A

Bug adhere to the guidelines.

[X] I made sure that this bug adheres to the guidelines.

Has not already been requested.

[X] I am certain this patch has not already been requested.

Has not already been implemented.

[X] I know that this patch isn't already in the latest version of the mod.

Wyvest commented 2 years ago

We’re not interested in skidding mods

RaptaG commented 2 years ago

We’re not interested in skidding mods

Besides that, this is a bug too, reported in the bug tracker and filling all the requirements for a patch request (according to Debugify's requirements)

isXander commented 2 years ago

Reopening because as RaptaG states, this is a bug. The item model fix mod is quite complex, if this was to be fixed the vanilla way, it shouldn't have any options and should "just work"

isXander commented 2 years ago

@PepperCode1 hi! Do you mind adding this mod into debugify?

PepperCode1 commented 2 years ago

My main issue with merging Item Model Fix into Debugify is precisely that it has multiple options. I will try to do some research to figure out why unlerp/outline still produces small gaps and based on what I come up with, further discussion can happen. The other problem is that Item Model Fix does not fix the block part of that bug.

isXander commented 2 years ago

Hiya. Thanks for your cooperation.

RaptaG commented 2 years ago

Model Gap Fix implements a better fix and it should be used instead of Item Model Fix, because it fixes it from the core of the problem. https://github.com/Fabulously-Optimized/fabulously-optimized/issues/473

RaptaG commented 1 year ago

Version 1.8 has completely fixed the bug on both block and item side, @isXander make sure to take a look!

isXander commented 1 year ago

Like I have previously stated, I don't have any knowledge about this part of Minecraft. I don't feel comfortable adding this fix at the current moment.