[Patch Request] MC-237017

isXander / Debugify

A mod aimed at fixing bugs found on the Mojang Bug Tracker

GNU Lesser General Public License v3.0

189 stars 42 forks source link

[Patch Request] MC-237017 #88

Open bobthehuman opened 2 years ago

bobthehuman commented 2 years ago

Mojang Bug Report ID

MC-237017

Mod Loader

N/A

Bug adhere to the guidelines.

[X] I made sure that this bug adheres to the guidelines.

Has not already been requested.

[x] I am certain this patch has not already been requested.

Has not already been implemented.

[x] I know that this patch isn't already in the latest version of the mod.

isXander commented 2 years ago

Potential to breakage of intended behaviour by datapacks.

TheFantasticLoki commented 2 years ago

Please reconsider patching this. I cannot make the datapacks I want because of this bug as the bug itself breaks intended behavior of datapacks

Andrew6rant commented 1 year ago

@bobthehuman @TheFantasticLoki Here is a simple one-mixin mod that fixes MC-237017: https://github.com/Andrew6rant/MC-237017-Fix/releases

I'm curious what the potential breakage is, @isXander. I'm no worldgen modder (at all, lol), but it looks to me like I just removed the strangely-hardcoded lava at Y-54 and below.

It shouldn't break datapacks because the only things in createFluidLevelSampler that datapacks can interact with (settings.seaLevel() and settings.defaultFluid()) stay the same between vanilla and my mod)

LKD-PIX commented 1 year ago

Fixing this will not break intended datapack behaviour as you can adjust this value via datapacks. Fixing this would only allow the value to drop below -54 via a datapack and depending on a bug, that Mojang aknowledged to fix in the future, in your datapack, doesn't seem supportable anyway. Also i've never seen anyone depend on this for any reason.

isXander commented 1 year ago

I guess this would be okay to implement as a gameplay fix (which are auto-off).