isXander / YetAnotherConfigLib

YetAnotherConfigLib (yacl) is just that. A builder-based configuration library for Minecraft.
GNU Lesser General Public License v3.0
91 stars 34 forks source link

Fix crash when opening config screen in neoforge #179

Closed Imajo24I closed 1 month ago

Imajo24I commented 1 month ago

When using neoforge, YACL crashes as soon as you open a config screen from any mod. This is due to neoforge using Access Wideners.

The forge part of this mod handles this by using loom.forge.convertAccessWideners.set(true). Theres no equivalent for neoforge, so this Pull Request fixes this crash, by adding an Access Transformer.

Tested this fix on fabric 1.20.1, 1.20.4 and 1.20.6, forge 1.20.1 and neoforge 1.20.4 and 1.20.6.

This fixes #176 and #132

isXander commented 1 month ago

I have fixed this and the build system now automatically converts AWs to ATs.

Faboslav commented 1 month ago

Is this fix out? It still happens on forge 1.20.1 https://mclo.gs/KN839lX