search

isaac-sim / IsaacLab

Unified framework for robot learning built on NVIDIA Isaac Sim
https://isaac-sim.github.io/IsaacLab
Other
2.09k stars 841 forks source link

[Bug Report] Possible typo on Tutorial Script <run_deformable_object> #1212

Closed cidxb closed 2 weeks ago

cidxb commented 2 weeks ago

On the tutorial Script of running deformable objet in line 112 there is a notation # write kinematic target to nodal state and free all vertices https://github.com/isaac-sim/IsaacLab/blob/main/source/standalone/tutorials/01_assets/run_deformable_object.py

but the code is in fact : nodal_kinematic_target[..., :3] = nodal_state[..., :3] nodal_kinematic_target[..., 3] = 1.0 cube_object.write_nodal_kinematic_target_to_sim(nodal_kinematic_target)

The meaning of the code is quite opposite. So maybe it is a typo?

mpgussert commented 2 weeks ago

Good catch! I think you may be right about it being a typo in the comment. It's very clearly writing the state TO the target, and not the target to the state. I'll check :)

mpgussert commented 2 weeks ago

confirmed! thank you for the find!