Closed isaac238 closed 11 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
itse-group | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Dec 12, 2023 6:01pm |
There is the whole loophole in the localhost/
directory to note down, that is on the nav you can go straight into user dash and also can just go to this directory.
NOTE: In the preview this does not happen, is this to do with login states, if so this should be addressed, as I have closed and hard refreshed my browser.
I think the positioning of the title is off:
Photo A:
Photo B: Photo C:
Showcase for creating multiple workout logs, if it's a daily limit fairs but no showcase of pervious data. When clicking view there's no showcase of dummy data not sure if you want to add that in a later issue.
User should be able to just create a workout log to a workout plan, they should be able to see all workout logs to that workout plan
Few things:
Photo D:
What is the button next to the menu button?
To add to 6. maybe could add tooltips to buttons that are vague and arbitrary when we get a chance or as we go along Please comment below with thoughts, not approving till this is talked through :)
1. Security
There is the whole loophole in the
localhost/
directory to note down, that is on the nav you can go straight into user dash and also can just go to this directory. NOTE: In the preview this does not happen, is this to do with login states, if so this should be addressed, as I have closed and hard refreshed my browser.
This is intended functionality and not a security issue. Its happening because login state is stored in cookies so that the user is auto logged in for X amount of hours until that token expires. If you visit /logout or clear these before trying again you will be redirected to home upon accessing /userdash.
2. Title & Brand
I think the positioning of the title is off:
* **__In green in Photo A__** EITHER the padding is **off** so there needs to be more space. Added on to this there is the fact the nav bar menu button is off to the right a lot more as shown closer in Photo B and Photo C: * **__In blue in Photo A__** OR it should be centred like the cards or to the left of the centred container:
Photo A:
Photo B: Photo C:
* And the brand needs extra padding.
Aligned menu button and title / subtitle heading. Breadcrumbs will be added at a later date so that the user knows their exact route
3. Showcase of data
Showcase for creating multiple workout logs, if it's a daily limit fairs but no showcase of pervious data. When clicking view there's no showcase of dummy data not sure if you want to add that in a later issue.
View is being handled in #54, added some previous workout logs to the test user to display other dates
4. Creating a workout log
User should be able to just create a workout log to a workout plan, they should be able to see all workout logs to that workout plan
This is a good suggestion, if we get some spare time after completing more core functionality it can be implemented
5. Create meal log
Few things:
* CSS between the two fields i.e the distance between the top field and the label as shown in Photo D * Can the time not be auto set to the current date and time * The user can create a meal log without putting in a time and date
Nice observations, ill implement these changes now :+1:
Photo D:
6. Unknown Button
What is the button next to the menu button?
This is still in development, its a information button as this page contains keybinds such as m for menu, esc to exit modals etc.
7. Tooltips
To add to 6. maybe could add tooltips to buttons that are vague and arbitrary when we get a chance or as we go along Please comment below with thoughts, not approving till this is talked through :)
This is a good idea will work on if we get time
I could also be logging in with wrong password for the user email, but pretty sure it weren't, I will try again then approve
Safari still doesn't login, chrome does
LGTM - other than the safari issue
Just checked the logs from pb, seems like the auth issue was incorrect password
Safari issue on #65 so not relevant to this branch for now as applies to all before it as well, will take a look at it if no one else does after i finish off the current feature :+1:
52 User dashboard render backend
Changelog
Changes from James' feedback
Issues