Update packages and fix deprecation messages

isaacabraham / azure-fsharp-helpers

A set of files which help provide better support for Azure with a number of F# projects.

MIT License

9 stars 5 forks source link

Update packages and fix deprecation messages #3

Closed toburger closed 6 years ago

toburger commented 7 years ago

After updating the packages from my own project I got deprecation messages from suave-appinsights.fs when building my project.

I have updated this project to the latest packages and tried to resolve the deprecation messages. I'm not sure if deleting the second argument for ExceptionTelemetry is the right thing to do, but I have trouble to find adequate documentation for AI.

isaacabraham commented 7 years ago

On holiday for next week - will review properly when I'm back - any reason why we now depend on Core 4.1 (are there any problems doing that?) and why the lock file is now like a million times bigger? :)

isaacabraham commented 7 years ago

But thank you for updating this - AI works quite currently now with the latest API so this does need doing- thank you for starting this off.

toburger commented 7 years ago

Sorry, didn't notice the change in size... The framework restriction should do the trick! Yeah, AI works fine, but the compiler warnings bugs me every time I build my project. ;)

toburger commented 7 years ago

AI has now removed the deprecated functionality in the latest 2.3 release.

toburger commented 7 years ago

Forget what I've said before: the deprecated methods aren't removed, but AI has now added a new overload for the StartOperation method, so the first argument cannot be inferred automatically. The master branch doesn't compile anymore, my pull requests compiles though...

toburger commented 7 years ago

Ok, there was more to do than that:

AI 2.3 adds the new overload, like said above
Suave 2.1 now depends on .NET Framework 4.6, so I had to update the solution to .NET 4.6.

Another possibility is to lock Suave to 2.0, but I think it is better to be on par with the latest release of Suave.

toburger commented 6 years ago

Any chance to merge this pull request? I'm using my branch in production since April and didn't encounter any problem.

isaacabraham commented 6 years ago

I'm terribly sorry for not having dealt with this sooner. Thanks For doing this - really appreciated.

toburger commented 6 years ago

No problem, thx for merging!