isaacabraham / vsts-fsharp

Azure Devops extension for F#-friendly tools
https://marketplace.visualstudio.com/items?itemName=isaacabraham.fsharp-helpers-extension
Apache License 2.0
13 stars 7 forks source link

Fake5 Runner task #16

Closed matthid closed 6 years ago

matthid commented 6 years ago

Basically a full-featured fake 5 runner task. Even added support for secret & encrypted variables to fake. However secret variables are only usable when a new Fake.BuildServer.TeamFoundation package is released (probably soon)

Similar to other tasks it will ask the user for a version and download and cache fake. The task currently requires DotNetCore to be available (the easiest way is to use the DotNetCoreInstaller task). We can consider lifting that requirement and download the self-contained package instead (but that was out of scope for the first implementation)

I guess docs are still missing

matthid commented 6 years ago

To dogfood this in FAKE I need to add another task in order to only generate the secret variable stuff, this task is probably not very useful to anyone else but FAKE, not sure if we should add it here (it might be useful if you are not using the runner task and still want to access the secret variables)?

matthid commented 6 years ago

I'm quite positive that this is ready, I hope I didn't break the PaketRestore task

matthid commented 6 years ago

Maybe for marketing purposes we should have a separate "fake" extension (to be independent of "F#")? However I'm fine with having everything here in a single repository. What do you think?

isaacabraham commented 6 years ago

@matthid I had the same thought re: FAKE - I'm happy to support either model :-)

isaacabraham commented 6 years ago

And thanks for adding this :-)

matthid commented 6 years ago

Thinking this further: "Paket" is not a "F# helper" either... Maybe we should rename this completely :/

isaacabraham commented 6 years ago

Yeah, it is a bit misleading. Not sure what to rename it to, as it has an F# runner there too.

matthid commented 6 years ago

The good thing about a single extension is that people need to ask their admins only once, while with 3 extensions (Paket, Fake, F#) they might need to ask multiple times :/

matthid commented 6 years ago

And realistically that the tasks are used and installed together makes completely sense to me