search

isaacabraham / vsts-fsharp

Azure Devops extension for F#-friendly tools
https://marketplace.visualstudio.com/items?itemName=isaacabraham.fsharp-helpers-extension
Apache License 2.0
13 stars 7 forks source link

Run F# script does not support F# 4.5 #29

Closed san-86 closed 5 years ago

san-86 commented 5 years ago

Description

Hi Isaac, thank you for these great tools, I have a F# library that is build with F# 4.5 , this is not complient with your Run F# script, I'm running it on a VS2017 Hosted Agent,

I have tried setting the FSharp version Parameter to 4.5 but that give me a Path not found error.

Repro steps

  1. Run a script that is build with F# 4.5 via the run F# script and set FSharpVersion parameter to 4.5

Expected behavior

I expect the Script to Run and the fsi.exe path to support F# 4.5

Actual behavior

the path is made to be somthing like : C:\Program Files (x86)\Microsoft SDKs\F#\4.5\Framework\v4.0\fsi.exe"

This path does not exist.

Known workarounds

I can make a simple CMD line task and then hardcode the path to a place on the Agent where F#4.5 is supported

Related information

isaacabraham commented 5 years ago

Mmmm. We probably should make the task configurable so that you can supply either the path to FSI or the version - the path seems to keeps changing every time there's a new FSI which is a pain. @matthid any thoughts on the best way to do this?

henrikhannemose commented 5 years ago

We are successfully using #30 as a fix for this issue. What are your thoughts on merging that PR, @isaacabraham?

isaacabraham commented 5 years ago

Ooops. Sorry. No complaints. let me merge and then release tomorrow. @matthid anything I need to know about with the release process changes since all the recent work you've done?

henrikhannemose commented 5 years ago

Thanks for merging the PR, Isaac!

Do you know what it takes to get the nuget package updated to be the most recent version? Right now I see Last updated | 9/13/2018

isaacabraham commented 5 years ago

Yes, I can push it - I just need to check with Mattias that nothing has changed recently. Sorry for the delay.

isaacabraham commented 5 years ago

@henrikhannemose just a heads up - i'm trying to deploy but there's an issue with the new script so i need to figure it out. please bear with me.

henrikhannemose commented 5 years ago

No problem. Thanks for the heads up. I appreciate your effort! :)

isaacabraham commented 5 years ago

@henrikhannemose right - can you check to see if the new version has your changes in it? Apologies again for the long time it's taken to push this through - hopefully this is now done, finally.

henrikhannemose commented 5 years ago

Thanks, @isaacabraham! It works just as expected 👍