isaacandy / google-toolbox-for-mac

Apache License 2.0
0 stars 0 forks source link

GTMHTTPFetcher crashes unhelpfully if beginFetchWithDelegate is called and request is nil #10

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. [[[GTMHTTPFetcher alloc] init] beginFetchWithDelegate:self ...];

What is the expected output? What do you see instead?

Expect a callback to the failed selector. Instead, I get a crash as the
null selector is sent to the delegate.

What version of the product are you using? On what operating system?

R70

Please provide any additional information below.

GTMHTTPFetcher.m:288 guards on failedSEL but actually uses failedSEL_,
resulting in the null selector. 

Original issue reported on code.google.com by ryandjoh...@gmail.com on 11 Dec 2008 at 7:06

GoogleCodeExporter commented 9 years ago
Here's a patch.

Original comment by ryandjoh...@gmail.com on 11 Dec 2008 at 7:15

Attachments:

GoogleCodeExporter commented 9 years ago
tx.  we'll fix this up, but there should be dev logs/asserts showing up for the 
missing data also.

Original comment by thoma...@gmail.com on 11 Dec 2008 at 7:32

GoogleCodeExporter commented 9 years ago
code landed.

Original comment by thoma...@gmail.com on 12 Dec 2008 at 3:19