search

isaacbernat / netflix-to-srt

Rip, extract and convert subtitles to .srt closed captions from .xml/dfxp/ttml and .vtt/WebVTT (e.g. Netflix, YouTube)
MIT License
749 stars 72 forks source link

Convert html entities #25

Closed maiux closed 4 years ago

maiux commented 4 years ago

Hello, maybe you can take in account html entities in vtt files. A quick and dirty solution is to change writing in: f.write(to_srt(html.unescape(text), fn[-4:]))

sorry, I'm new to github and I don't know how to propose a change in code, yet :)

isaacbernat commented 4 years ago

@maiux no problem, thanks for the comments. Could you write the changes on your fork of this repository and write a Pull Request? This guide may help you https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork

isaacbernat commented 4 years ago

@maiux are you looking into it? If you propose some code snipped here I can check it too. Otherwise I'll close the issue. Thanks

isaacbernat commented 4 years ago

@maiux I am closing the issue for now. Feel free to reopen it if you have a sample file where the current script won't work properly and I will look into fixing it. Or you can also send me a PR. Thanks