isaacbernat / netflix-to-srt

Rip, extract and convert subtitles to .srt closed captions from .xml/dfxp/ttml and .vtt/WebVTT (e.g. Netflix, YouTube)
MIT License
749 stars 72 forks source link

Extra digits on ms #6

Closed TRox1972 closed 8 years ago

TRox1972 commented 8 years ago

Could you add a option so that all the ms digits are included? If you have a subtitles file with say 350 "points" it can be skewed a total of 0.0009 x 350 = 0.315 seconds at the end if you don't include all the digits.

isaacbernat commented 8 years ago

I tried adding those 4 extra decimal places but then again my benchmark player (VLC) will simply refuse to show the subtitles. I think the first priority should be to try to keep this compatible with most players.

In any case AFAIK the maximum skew would be of 0.0009 seconds. Since each timestamp has an absolute value and not an incremental one they are independent. That's imho totally acceptable.

Is there anything else you'd like to discuss?