Link against libh3.a in Wasm, and remove outdated WASM_LINK_TIME_FLAG

isaacbrodsky / h3-duckdb

Bindings for H3 to DuckDB

Apache License 2.0

170 stars 8 forks source link

Link against libh3.a in Wasm, and remove outdated WASM_LINK_TIME_FLAG #119

Closed carlopi closed 3 months ago

carlopi commented 3 months ago

Those changes were lost at some point while improving extension-ci-tools.

I need to make the duckdb-wasm build perform actual tests, but that I will sort it independently, for now I think it would be cool to have h3 work successfully for duckdb-wasm again.

I built this on my fork, and tested locally. I will add the relevant test infra to extension-ci-tools.

carlopi commented 3 months ago

@isaacbrodsky: could you possibly file a PR against duckdb/community-extensions bumping to latest main? Thanks!