This may fix #17. I am not entirely sure how the function sort-of worked before, but I am guessing there was a use-after-free on the resulting string vector (or in any case the resulting string vector was invalid.) This changes the function to match the string concat function from duckdb, and adds a test to confirm it works as intended. There is some risk that this doesn't fully fix the issue, my intuition would be if it fails it would be on a larger file.
This may fix #17. I am not entirely sure how the function sort-of worked before, but I am guessing there was a use-after-free on the resulting string vector (or in any case the resulting string vector was invalid.) This changes the function to match the string concat function from duckdb, and adds a test to confirm it works as intended. There is some risk that this doesn't fully fix the issue, my intuition would be if it fails it would be on a larger file.