search

isaacbrodsky / h3-duckdb

Bindings for H3 to DuckDB
Apache License 2.0
170 stars 8 forks source link

Upgrade to DuckDB v0.10.0 #82

Closed isaacbrodsky closed 8 months ago

isaacbrodsky commented 8 months ago

Replaces #81

isaacbrodsky commented 8 months ago

Note that on Windows I needed this change, which doesn't seem to be applicable for CI:

$ git diff
diff --git a/Makefile b/Makefile
index d81ae87..03fb4b4 100644
--- a/Makefile
+++ b/Makefile
@@ -10,10 +10,11 @@ DUCKDB_PATH="/duckdb"

 # For non-MinGW windows the path is slightly different
 ifeq ($(OS),Windows_NT)
-ifneq ($(CXX),g++)
+# TODO: Doesn't match what should actually happen
+# ifneq ($(CXX),g++)
        TEST_PATH="/test/Release/unittest.exe"
        DUCKDB_PATH="/Release/duckdb.exe"
-endif
+# endif
 endif

 #### OSX config
eknowles commented 8 months ago

thank you so much 🙌