search

isaaccorley / torchseg

Segmentation models with pretrained backbones. PyTorch.
MIT License
91 stars 7 forks source link

Ruff #23

Closed isaaccorley closed 3 months ago

isaaccorley commented 3 months ago

Ruff appears to be an alternative to using separate black/flake8/isort/pyupgrade/pydocstyle. This PR transitions the repo to use ruff.

isaaccorley commented 3 months ago

I'm surprised there are no pydocstyle changes, given that the original pydocstyle contains a lot of bugs that prevent detection of issues. Do you need to add some kind of configuration setting to enable pydocstyle checking?

I'll do that in a separate PR. The library itself didn't have many docstrings for the classes and functions and I haven't had the time to go through and add all of them.

adamjstewart commented 3 months ago

README still references the old tools

isaaccorley commented 3 months ago

@adamjstewart I made some updates and fixed the actions. Note that ruff format doesn't run isort you need to run ruff check --fix

isaaccorley commented 3 months ago

Surprised no code changes were required, I guess the repo is just smaller and simpler than TorchGeo.

It's because I don't have pydocstyle enabled. When I do that's going to be a huge PR to fix 305 errors lol