search

isaacfreeman / kakano-obsidian-theme

A theme for the Obsidian note-taking app, with strong color to distinguish different vaults, and support for many plugins.
MIT License
10 stars 1 forks source link

paragraphs getting removed in reading mode #11

Open incantatem1 opened 3 weeks ago

incantatem1 commented 3 weeks ago

can you add an option for them to stay? i have some chat history like documents where the lack of paragraphs looks really confusing in this theme, otherwise i'm a quite big fan of it. am i missing an option somewhere which does that? i honestly have no idea and i'm also not sure what CSS element does this, i'd prefer it as a toggleable option

isaacfreeman commented 3 weeks ago

Thanks! This was just a bug in my opinion: it doesn't need an option it should just keep paragraphs in reading mode.

I'm not sure when this happened, as I seldom use reading mode myself, but try version 3.0.7 and let me know if it's working for you. It should behave similarly to the default theme: paragraph breaks keep their spacing, but multiple breaks following each other collapse into a single break in reading mode.

incantatem1 commented 3 weeks ago

just updated, paragraphs are there now!

what do you mean with the last sentence though? i never observed such behaviour of paragraphs.... do you mean like if i press enter multiple times in a row?

some things:

isaacfreeman commented 3 weeks ago

i actually liked how narrow the editor content was in the previous version in reading mode, can you restore that while keeping the paragraphs? i feel like it was part of this themes unique character

It's always interesting which parts appeal to people! Do you like it narrower just in reading more, or in both reading mdoe and live preview?

I've been trying to keep reading mode and live preview as similar as I can make them, but since I don't use reading mode much anyway, and there are limitations preventing them from being perfectly identical, perhaps I should understand more about what people want from reading mode.

it seems to add additional paragraphs in editing mode now

The difference in behaviour comes if you have two consecutive empty lines. In editing modes (live preview mode or source mode) these will appear as two separate lines, but in reading mode they'll be collapsed into a single empty line. This derives from the underlying behaviour of Markdown: reading mode is equivalent to rendering Markdown as HTML, and collapsing empty whitespace is standard HTML behaviour.

incantatem1 commented 3 weeks ago

hmm, i liked the narrowness in reading mode specifically. but i actually wouldn't mind if it would be narrow in editing mode as well. you could also make it a toggle in case not everyone likes it? i always think that's a good idea for such specific style stuff, not everyone likes everything, but i'm not sure to which extent a toggle is possible.