isaacfreeman / kakano-obsidian-theme

A theme for the Obsidian note-taking app, with strong color to distinguish different vaults, and support for many plugins.
MIT License
10 stars 1 forks source link

Dropdown Menus are not readable. #8

Open WinnerWind opened 5 months ago

WinnerWind commented 5 months ago

Hi there! So sorry to bring up another issue. This issue has been here since February (possibly before!) but because of work I wasn't able to compile a bug report. There's something to do with the dropdowns and using Kakano. image Latest v of Kakano

image Latest v of Kakano

image This is Kakano v2.9.4

As you can see from the screenshots, whenever a dropdown menu is enabled, it is jet black and the text seems to match it, making the text unreadable. Text can only be read if the cursor is hovered over the item. You can see from the first screenshot that this bug works in a sandbox vault with ONLY the theme enabled, and no style settings. This exists for EVERY dropdown menu in Obsidian. Changing the theme to light does not alleviate the issue, now the dropdowns become white (Sorry for your eyes!) image

Note : I switched from Windows to Arch Linux, but this bug existed in Windows back in February - Early March. This is the Flatpak version of Obsidian. Sorry if this bug report feels a bit rushed.

Edit : Similar to #4 but for dropdowns and not context menus.

isaacfreeman commented 5 months ago

Thanks @WinnerWind!

I've made a small change in version 2.16.4 that may help, however I'm currently working blind as I can't reproduce the problem on macOS.

However, it's useful information that you're seeing the same thing on Linux. I don't currently have access to a Windows machine, but I'll look into running Linux on my Mac under VirtualBox to see if I can see it. That should also help me with #6, which is also a cross-platform issue.

WinnerWind commented 5 months ago

The change in V 2.16.4 works perfectly! image

Edit : Virtualization software may help to solve such issues but do remember that it's not perfect and may introduce more issues.

isaacfreeman commented 4 months ago

Virtualization software may help to solve such issues but do remember that it's not perfect and may introduce more issues.

For sure. Especially for Windows, I may need to see if I can borrow a machine from somebody. Seems odd that I don't have one in the house, but I've always been a Mac user (at least since I stopped being an Amiga user).

WinnerWind commented 4 months ago

Hi there! I do have a windows machine (I'm on a dual-boot setup) so in case you ever need to do some testing I can help out remotely.

isaacfreeman commented 4 months ago

I do have a windows machine (I'm on a dual-boot setup) so in case you ever need to do some testing I can help out remotely.

That would be awesome. Could I get current screenshots on Windows for each of the three window frame styles? Pop them in a new issue here.

Screenshot 2024-04-23 at 17 10 32

I'm particularly interested in the layout at the tops of the windows. There are some older screenshots in #6 – I've made some changes since then, but I'm not certain yet that I have it right. It would be great to see what it currently looks like to see what else is needed.