search

isaacharrisholt / quiffen

Quiffen is a Python package for parsing QIF (Quicken Interchange Format) files.
MIT License
34 stars 30 forks source link

First !Account definition missed due to !Option:AutoSwitch #92

Closed lcmcninch closed 3 weeks ago

lcmcninch commented 3 weeks ago

In your most recent release, you included a change (#90) to ignore !Clear:AutoSwitch lines. I'm getting similar lines in Quicken exports: !Option:AutoSwitch. I'm not very familiar with these file formats, and as the PR states, these sections aren't defined in the standard. So, I'm not sure if this !Option section is the cause of the issue I'm having, or if it's a bug.

Here's a snippet from the top of a sample file I'm working with that demonstrates the issue. 

!Option:AutoSwitch
!Account
NChecking
TBank
^
NSavings
TBank
^
!Clear:AutoSwitch
!Option:AutoSwitch
!Account
NChecking
TBank
^
!Type:Bank 
D8/ 2'24
U5.00
T5.00
CX
POpening Balance
L[Checking]
.
.
.

When reading this file, it ignores everything up until the first !Type:Bank, at which point there is no account so it creates the "Quiffen Default Account". It seems like everything between !Option:AutoSwitch should be ignored. But because sections are split on ^, it's also skipping over the !Account for "Checking", effectively ignoring the definition of the account.

Any thoughts? I'd be happy to contribute a PR addressing this, but I'm not sure if I'm on the right track. I'll tinker with it a bit and see if I can come up with something that works for me, but I wanted to also get input from here in case I'm missing something obvious.

FYI: I'm on the latest release of Quiffen: 2.0.11, and I'm exporting a very simple set of accounts from Quicken Classic R59.18.

lcmcninch commented 3 weeks ago

I did some tinkering and came across a fairly simple solution. It was simple enough that I thought it'd be easier to just submit a PR (#93) than describe it here. But I'm open to discussion if there's something I've missed.