search

isaacharrisholt / quiffen

Quiffen is a Python package for parsing QIF (Quicken Interchange Format) files.
MIT License
34 stars 30 forks source link

Ignore !Option lines #93

Closed lcmcninch closed 2 weeks ago

lcmcninch commented 2 weeks ago

Similar to #89, Quicken QIF exports (sometimes?) include !Option:AutoSwitch sections. The proposed solution simply ignores those lines just like the !Clear lines are are ignored as of that PR.

As I mentioned in #92, I have a suspicion that everything between the two !Option:AutoSwitch lines could be ignored, but this seems to work for me for now.

I added a test case, but I'm not sure how this would fit into your release process so I didn't make any changes to the revision. Please let me know if you have any thoughts or if there's anything else I can do.

lcmcninch commented 2 weeks ago

Thanks for taking a look! I'm not very familiar with Github actions so I'm not entirely sure what I'm looking at. But the failure we're seeing now seems to have to do with python 3.9 on windows, specifically. There are a bunch of warnings but the error seems to be when running tox. All it says is that the process completed with exit code 1. Digging into the log, it looks like it failed on "py312":

image

image

Looking at what seems to be a history of these test runs, it looks like this particular one (windows-latest, 3.9) started failing somewhere around 6 months ago.

All that said, I'm not entirely sure what the issue is. Somewhere during the install process, some function in virtualenv is getting None when it expects a string. But I'm not sure where in the process that is. I assume it's part of poetry? Regardless, I don't think it was caused by the changes in this PR.

The only detail I can add is that when I installed on my system using pip, I had issues with dependency conflicts with numpy and pandas. I had to re-install the latest pandas version overriding the Quiffen dependencies. That doesn't appear to be related but worth mentioning since the issue seems to do with installation.

Let me know if there's anything else I can do to help.

isaacharrisholt commented 2 weeks ago

I'm gonna assume this is a failure in the test runner and get it all merged

lcmcninch commented 2 weeks ago

Excellent, thank you!

isaacharrisholt commented 2 weeks ago

Thanks for your contribution!