search

isaachinman / wundershine-native-app

0 stars 0 forks source link

Support for PNGs #108

Open isaachinman opened 6 years ago

isaachinman commented 6 years ago

Is your feature request related to a problem? Please describe. Currently we only support JPG images. From Mick:

Speaking of which, some of the creative apps that I want to feature actually output in PNG. Including the one that will work best for marketing / demo prints at POS purposes.

Describe the solution you'd like Support both JPG and PNG images.

Describe alternatives you've considered N/A.

Additional context Everything is geared towards JPG at the moment. While I have built all levels of the system to be able to work with more than one image format, we might hit unexpected issues when it comes to implementing this.

What about HuigHaverlag, and other printers? How is transparency dealt with, when it comes to printing? What about the option of using Cloudinary to simply convert PNGs to JPG upon upload? They make it very easy.

I also wonder if this affects colour space concerns.

isaachinman commented 6 years ago

Initial support added with 087952e. This needs extensive testing to ensure everything is working as expected. Depending on @Tintels opinion about transparency, I would suggest that we convert all PNG images directly to JPG immediately upon upload, as there is no such thing as transparency in printing anyways, and the JPG file format is going to be smaller in size.

Tintels commented 6 years ago

I'm fine with converting to JPEG immediately. Initial test was succesful. Will do some more testing with PNG and then close the issue if I don't encounter problems.

isaachinman commented 6 years ago

Sounds good. JPEG conversion is probably something to discuss with HuigHaverlag. It's probably only a good idea to automatically convert if we: (a) need to, (b) should do so to improve print process/quality.

isaachinman commented 6 years ago

I take that back - I would need to do some testing on this. I believe we can upload as PNG and then make all future queries as JPG, and Cloudinary will retain the original PNG master and simply serve JPGs as transformations.

Tintels commented 6 years ago

These PNG files fail to import in our app. Smaller versions (below 6MB) do import.

https://drive.google.com/open?id=1JciGBZR7fDanYabXzGBFe_9ZWTKcazzH https://drive.google.com/open?id=12NbOYseoMzNDX3IEXJvZ6zeNgyx3tFhE

isaachinman commented 6 years ago

Ah, I think I tracked this down. I recently switched the beta/dev version of the app to communicate with an entirely separate Cloudinary account, so that all our beta/test data lives in a disposable and removed account. Our production account is the one with special limits on bandwidth/storage/file-size. So unfortunately, we cannot test our large-file-size uploads except in production environments.

This is double-checkable by simply testing in beta environment with a large JPG (but under 55mb). Here's one: https://upload.wikimedia.org/wikipedia/commons/3/30/04U_Dec_28_2012_0230Z.jpg.

It also fails. So, we need to make a note to double check this once it rolls to production, but it should be fine.