isaacholt100 / bnum

Arbitrary, fixed size numeric types that extend the functionality of primitive numeric types in Rust.
https://crates.io/crates/bnum
Other
67 stars 8 forks source link

Add minimum rust version #34

Closed chipshort closed 8 months ago

chipshort commented 8 months ago

Hi, are you interested in adding the minimum rust version to Cargo.toml? That way people with a dependency on the crate (direct or transitive) get an error message that is a bit more helpful. Currently, if you compile with pre-1.65 Rust, you just get a bunch of errors like this:

no method named cast_mut found for raw pointer *const [u16; N] in the current scope

Only downside is that it has to be kept in sync with the code to be useful.

isaacholt100 commented 8 months ago

Hi @chipshort, sorry for the slow reply, I've been very busy over the last few weeks. Yes, this is a good idea, I will add this to the next version (v0.9.1). I'll just edit this PR to merge into the v0.9.1 branch first, which I'll then merge into the master branch (because the master branch always contains the code for the latest version).

isaacholt100 commented 8 months ago

v0.9.1 just published now, thanks again!