search

isaacholt100 / bnum

Arbitrary, fixed size numeric types that extend the functionality of primitive numeric types in Rust.
https://crates.io/crates/bnum
Other
73 stars 10 forks source link

feat(serde): borsh #42

Closed dzmitry-lahoda closed 3 months ago

isaacholt100 commented 3 months ago

Thanks for this PR @dzmitry-lahoda! Sorry for taking a while to respond to this, I'm very busy at the moment. I'll merge this into the latest branch, add a few changes (basically just increase the version number), then publish a new version. Is this a feature you need soon/now? If so then I'll do my best to do this ASAP, can't promise exactly when unfortunately, it should be within a week though I hope.

dzmitry-lahoda commented 3 months ago

no worries, not ASAP. we use bnum as direct dep only, so fork works for us clean. thanks

isaacholt100 commented 2 weeks ago

@dzmitry-lahoda I will publish 0.12.0 soon with borsh support - looking at the line you added for it in Cargo.toml, I was wondering whether the "rc" and "std" features are necessary? Everything seems to compile without these enabled. If you could let me know ASAP that would be appreciated, as then I can include borsh in the next version.

dzmitry-lahoda commented 2 weeks ago

you are right, "rc", "std", are no needed. that is just line from our repo. sorry.

isaacholt100 commented 2 weeks ago

Thanks for replying so quickly!