isaackd / AnnotationsRestored

Brings annotation support back to YouTube
GNU General Public License v3.0
156 stars 8 forks source link

Description limits length of annotation data to 5000 characters #2

Closed tech234a closed 5 years ago

tech234a commented 5 years ago

YouTube descriptions limit users to 5000 characters, and I tried to place a converted set of annotations in the description, but it was too long. Can we store annotations in the extension storage for testing?

tech234a commented 5 years ago

I noticed the new format requires significantly fewer characters than the original one, so that's a step in the right direction. Is any important data lost?

isaackd commented 5 years ago

YouTube descriptions limit users to 5000 characters, and I tried to place a converted set of annotations in the description, but it was too long.

Yeah, ideally new annotations would be uploaded to a server just like the older ones, but I don't have access to one. I chose the description instead of, for example, comments because they don't require scrolling to load.

Can we store annotations in the extension storage for testing?

I'll add a popup when you click the extension's icon that allows you to load either YouTube or converted annotation data.

I noticed the new format requires significantly fewer characters than the original one, so that's a step in the right direction. Is any important data lost?

I need to look at more annotation data, but the only thing I know of right now that isn't included is appearance data, such as background and foreground colors, background opacity, and text size. I think most of the size savings are from the repetitiveness of the XML tags and reducing super long links that are just time stamps like this: https://www.youtube.com/watch?annotation_id=annotation_1265285409&ei=R_s7XKT_KsHCigTVw624Ag&feature=iv&src_vid=jqUu0vIh4Ig&v=jqUu0vIh4Ig#t=1m32.6s to just as=92

isaackd commented 5 years ago

The popup has been added

tech234a commented 5 years ago

Nice work on the popup! Also, I added support for Omarroth's temporary API in #7.

isaackd commented 5 years ago

Addressed with #11 and 465116496bcf463e2ab39d0d0d30c8034a513212