search

isaackd / AnnotationsRestored

Brings annotation support back to YouTube
GNU General Public License v3.0
159 stars 8 forks source link

Firefox version is stuck on "Checking for annotations..." & Annotations do not show up. #68

Open jaff80 opened 1 year ago

jaff80 commented 1 year ago

Device Info: Computer: MacBook Pro 13-inch, M1, 2020 OS: MacOS Sonoma 14.0 Firefox version: 119.0.1 AnnotationsRestored version: 1.2

Describe the issue: When using the Firefox version of the Add-On, it gets stuck on "Checking for annotations..." So far, I only got it past the message by clicking the video in the search results. Even after this, the annotations do not show up. Clicking on the timestamps does not fix it, and when the page is refreshed, you are back at the "Checking for annotations..." error.

Steps to reproduce the issue: ("Checking for annotations..." error)

  1. Watch a YouTube video (Only watch it by pasting the URL into the address bar)
  2. Refresh the page to avoid the message "No video playing"
  3. Click on the AnnotationsRestored Add-On. You should see the "Checking for annotations..." message.

https://github.com/isaackd/AnnotationsRestored/assets/113552154/ac6e7dcf-ffff-44bb-9a02-bc9a3eea4681

Steps to reproduce the issue: (Annotations do not show up.)

  1. Search for a YouTube video
  2. Click on a video
  3. Click on the AnnotationsRestored Add-On. You should see the list of annotations, but none show up.

https://github.com/isaackd/AnnotationsRestored/assets/113552154/2ba7f1e2-b301-4c17-a619-5262edaabfa9

Additional notes: The Annotations Restored toggle in the YouTube video player settings is gone. Usually, this is fixed by refreshing the page, but it didn't work this time.

jaff80 commented 1 year ago

The version on the Google Chrome Webstore seems more up-to-date than the one on the Firefox Add-On store. I also believe that this issue is related to https://github.com/isaackd/AnnotationsRestored/issues/57. BTW, here is the video I used for testing: https://www.youtube.com/watch?v=k9CJpgjEPZ0.

jaff80 commented 12 months ago

For anyone reading this in the future, I've reached out to @isaackd on the AnnotationsRestored Discord server about this issue, and they said that they are unable to log into their AMO account because they changed their phone number and are unable to locate their 2FA codes. I also asked if Firefox users could install the Add-on from file, but I have not gotten a response yet.

image image image
jaff80 commented 11 months ago

Update: @isaackd said they can make a .xpi file. Sorry that I commented on this update late!

image

TakuikaNinja commented 10 months ago

I just had a look at this. It seems like it's failing sometimes because it can't find the movie_player element, despite it existing. I had to clear the browser cache/cookies and refresh the video page a few times to get it working again. The toggle being missing from the video player settings is really odd since it appears to be finding the menu (no warnings logged, and the relevant function is called) but still fails to inject the toggle. I have YouTube Redux installed but the behaviour seemed to be the same with or without it.

Device Info: Computer: HP ENVY 15-j026tx Notebook PC OS: EndeavourOS (Arch-based) Firefox version: 121.0 AnnotationsRestored version: 1.2 (tried with a locally built version as well)

SSM240 commented 8 months ago

I'm also on Firefox, and it seems like the behavior I'm getting is:

WormChickenWizard commented 2 months ago

I'm using ungoogled chromium and I am able to replicate this issue. OS: Win 10 22H2 chrome: 127.0.6533.119 extension: 1.2.1

I used this video as a test: https://www.youtube.com/watch?v=x1JA24KCAjE

Creating a new tab and pasting the URL in directly leads to the perpetual "Checking for Annotations..." Going to youtube.com, pasting the url into search, and selecting the video in the results pulls up the video with the annotations loaded.