Only read file contents after checking extension

isaaclyman / novel-word-count-obsidian

Obsidian plugin. Displays a word count or other statistic for each file, folder and vault in the File Explorer pane.

https://obsidian.md/plugins?id=novel-word-count

MIT License

77 stars 7 forks source link

Only read file contents after checking extension #54

Closed RLGingerBiscuit closed 9 months ago

RLGingerBiscuit commented 9 months ago

Fixes #55.

isaaclyman commented 9 months ago

Thanks for the PR! This is a good fix. I have just one question, to follow.

isaaclyman commented 9 months ago

I'd like to test my changes in commit d7d4087 on your big 7z file. Do you mind fetching the commit and taking a look? Or providing a comparable file I can include in my test vault?

EDIT: Changes are also available in release 2.23.5 if that's easier.

RLGingerBiscuit commented 9 months ago

Yup, that appears to fix the issue. My vault now works correctly with this plugin and it's set accordingly in the cache. Thanks. As for the file, it's just a 1GB+ .7z file.

isaaclyman commented 9 months ago

Awesome. Thanks again for your help.