Closed b-barry closed 6 years ago
πI think you wrote more in this PR than I wrote initially. Could you talk through the changes you made and your reasons for making them?
@isaacplmann I have made some update in my previous comment. Could you review it? Sorry for the big PR, we updated it in my project to fit our requirement. Your project was a good start for us π―
Thanks for the run down. Why not use the same cypress
builder and use configuration option to switch to open
mode instead of the default run
option?
It looks like there's just a couple lines of code that are different between the two builders. And it would save on writing an abstract
class to share the code between the two.
Oh, and I forgot to say thanks a lot for contributing! This is awesome work. You started using it in your app before I got around to it.
@isaacplmann Update done. Do you have other remarks?
Looks great. Thanks! π
Changelog:
Add new options for the builder i.e mode, reporterPath and env. We could add more if people request it
Add sample to show how to execute cypress when his configuration is in the root folder
Add sample to show how to execute cypress when his configuration is in the app folder
Add sample to show how to execute cypress in run or open mode
Breaking Changes:
The previous builder is replaced by the
cypress-run
, you may need to update thepath
of theroot
property of the project in theangular.json
The version was bumped to 1.0.0