search

isaacplmann / ngx-tour

Product Tour Built in Angular
https://isaacplmann.github.io/ngx-tour
MIT License
243 stars 100 forks source link

Is it support ionic3 app #73

Closed sandeeppatel344 closed 3 years ago

sandeeppatel344 commented 6 years ago

i am trying to integrate this functionality but its give me error for routing

isaacplmann commented 6 years ago

I'll need more information than that if you want me to help you.

TreatDarren commented 6 years ago

@sandeeppatel344 Ionic 3 uses it's own custom router rather than Angular/router, you will probably have to write your own routing solution using callbacks but it should be really simple.

For what it is worth, Ionic's routing is getting a full rewrite in Ionic 4 (3.x is a mess for any serious non-mobile routing) so if you do it, I would recommend that you keep it rather generic.

isaacplmann commented 6 years ago

@TreatDarren thanks for providing some clarity.

Yes, the library is pretty tied to the angular router right now. However there are only a handful of places that use the router - all in ngx-tour-core/src/tour.service.ts.

I'd be open to a PR that abstracts that dependency away so that people could provide their own router logic. Any router implementation would need to provide two things: (1) a way for the tour service to know when the router is navigating to a new route and (2) a way to tell the router to go to a specific route and be notified when that route is loaded.

isaacplmann commented 6 years ago

I'm happy to coach anyone who wants to try their hand at the PR.