search

isaacplmann / ngx-tour

Product Tour Built in Angular
https://isaacplmann.github.io/ngx-tour
MIT License
246 stars 100 forks source link

ngx-tour-core npm package not updated to latest code - current latest version is 3 months old #88

Closed ghost closed 6 years ago

ghost commented 6 years ago

https://www.npmjs.com/package/ngx-tour-core

The custom button titles is still missing from the current latest version of ngx-tour-core 2.0.0

isaacplmann commented 6 years ago

ngx-tour-core@2.1.0 has been published.

ghost commented 6 years ago

Should we also need to update the package.json in the sub projects that rely on it?

https://github.com/isaacplmann/ngx-tour/blob/master/ngx-tour-console/package.json https://github.com/isaacplmann/ngx-tour/blob/master/ngx-tour-ngx-popper/package.json https://github.com/isaacplmann/ngx-tour/blob/master/ngx-tour-ngx-bootstrap/package.json https://github.com/isaacplmann/ngx-tour/blob/master/ngx-tour-ng-bootstrap/package.json https://github.com/isaacplmann/ngx-tour/blob/master/ngx-tour-md-menu/package.json

I can create a PR if that would be easier?

isaacplmann commented 6 years ago

Yes. We'll need to do that. I already did for ngx-popper. PR is welcome

On Feb 13, 2018 12:19 PM, "damo1884" notifications@github.com wrote:

Should we also need to update the package.json in the sub projects that rely on it?

https://github.com/isaacplmann/ngx-tour/blob/master/ngx-tour-console/ package.json https://github.com/isaacplmann/ngx-tour/blob/master/ngx-tour-ngx-popper/ package.json https://github.com/isaacplmann/ngx-tour/blob/ master/ngx-tour-ngx-bootstrap/package.json https://github.com/isaacplmann/ngx-tour/blob/master/ngx-tour-ng-bootstrap/ package.json https://github.com/isaacplmann/ngx-tour/blob/master/ngx-tour-md-menu/ package.json

I can create a PR if that would be easier?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/isaacplmann/ngx-tour/issues/88#issuecomment-365338203, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0lQBigtpisWwfvxvT5EmqZlp2XqvQyks5tUcQmgaJpZM4SC9Tf .

ghost commented 6 years ago

https://github.com/isaacplmann/ngx-tour/pull/89

ghost commented 6 years ago

Do you have to redeploy each of the npm packages every time there is a code change?

isaacplmann commented 6 years ago

Yes, I update the version number and the changelog and then publish them to npm.