isaacs / cluster-master

Take advantage of node built-in cluster module behavior
ISC License
276 stars 44 forks source link

Option env is not being passed on to workers. #7

Closed rikkert closed 12 years ago

rikkert commented 12 years ago

The env property of the passed option object is not used correctly. This removes the current use and passes the env property to the fork method of cluster.

isaacs commented 12 years ago

Hm. Indeed.

That API in node is unsavory. You should be able to do cluster.setupMaster({ env: whatever }), not be forced to pass it in as the fork() arg.

Anyway, we can't do that in 0.8 anyway, so pulling your fix for now.

rikkert commented 12 years ago

Yep, that would make sense.