search

isaacs / github

Just a place to track issues and feature requests that I have for github
2.21k stars 129 forks source link

Code review on issues (not only for pull requests) #139

Open noctarius opened 10 years ago

noctarius commented 10 years ago

It would be cool to add the same code review (sourcecode line comments) for issues as for pull requests. In this case you could just start commenting on every line of the current sourcecode (maybe just on one branch at a time).

That would be very good for code reviews (not only on pull requests) but even to discuss possible better implementations.

Thanks Chris

patcon commented 10 years ago

Can't quite imagine how to make this work elegantly in practice... Can you explain more?

noctarius commented 10 years ago

I would expect it to be available when opening a new issue (maybe a new kind of workflow next to pull request and issue) where you can add comments to sourcecode lines just as you would for pull requests. When you're finished adding your comments you can create an issue from that?

So what I would imagine an example is: I see some code / implementation that may should be changed because it has a todo or fixme comment / annotation so I do some research on how to make it better but I want to discuss this first before starting to implement it (maybe for a later pull request). So I search the sourcecode area and say ok please create a "code review" (maybe "code discussion"?) and add my comment and some pseudo code. Now I can have the same style of discussion as github features for comments on source of pull requests. When finished or a decision is nearly made I'll make it an issue (task) from it that may includes the full discussion.

Something like that, does that make sense? :)