search

isaacs / github

Just a place to track issues and feature requests that I have for github
2.2k stars 128 forks source link

Change color merge button #1416

Open Sjardo opened 5 years ago

Sjardo commented 5 years ago

ATM all buttons are green for submitting and grey for canceling or undoing. The merge button is green as well but is a pretty big deal. It could break your software and that sucks! With a simple change of color, users are less likely to press the merge button by accident!

For example:

screen shot 2018-11-27 at 4 49 28 pm

It might not be fancy, but it does the job well. I'm 100% sure someone deal better with colors ho...

brandyscarney commented 5 years ago

This would be helpful to us, as well. We require all of our PRs to be squashed over at Ionic and the button seems to reset randomly for some of our employees back to a normal merge. This has caused accidental normal merges several times. Due to this we have disabled the normal merge button for the repository, and we then re-enable it each time we need to use it.