isaacs / github

Just a place to track issues and feature requests that I have for github
2.2k stars 128 forks source link

Change the target branch of a pull request #18

Closed tjfontaine closed 7 years ago

tjfontaine commented 10 years ago

It can be necessary to pick a different target branch for a pull request if you accidentally select the wrong one, or perhaps you're asked to rebase the branch against a development branch vs a stable branch.

thedrow commented 10 years ago

Oh this is much needed :+1:

jzaefferer commented 10 years ago

What's wrong with closing and opening a new pull request? You can still reference the previous one if the discussion is of any value.

thedrow commented 10 years ago

@jzaefferer There's nothing wrong with it. It's simply inconvenient.

tjfontaine commented 10 years ago

It's also very tedious, and having to open a second because the goal post has changed for a milestone seems inconvenient, especially since I can rebase the target multiple times but in the end all utility of the comparison is lost because it's not pointing to anything sane

piedar commented 10 years ago

I too would appreciate this feature.

It would also be handy if you could set the pull request target to a new branch. github could create a "pending branch" on upstream's repo. When the pull is merged, it creates - and immediately pushes to - the upstream branch.

prust commented 10 years ago

:+1:

amirnissim commented 10 years ago

+1

bc-ben-buchanan commented 10 years ago

+1

delliott90 commented 10 years ago

+1

anton-rudeshko commented 10 years ago

+1

kuanxu commented 10 years ago

+1

reinert commented 10 years ago

+1

odedniv commented 10 years ago

+1

sjaeckel commented 10 years ago

:+1:

jaen commented 10 years ago

Also in favour. Just did a pull request to wrong branch and ended up with the longest diff.

kspangsege commented 10 years ago

:+1:

marekmurawski commented 10 years ago

:+1:

mvdkleijn commented 10 years ago

:+1:

nicwortel commented 10 years ago

:+1: this would be a great improvement. I've sent an email to GitHub support, referencing to this issue.

timpokorny commented 10 years ago

+1

nicwortel commented 10 years ago

I received the following response from GitHub:

Thanks for your feedback about pull requests, Nic!

I've added your suggestions to our internal feature request list. We don't comment publicly about if or when we may implement a particular feature until it has shipped, however your feedback has definitely been recorded.

Let us know if you have any other suggestions.

Cheers, Ivan

mvdkleijn commented 10 years ago

I received the following response from GitHub:

That's their standard "we can't comment" reply. :smile:

ams2990 commented 10 years ago

+1

nathanbrauer commented 10 years ago

:+1:

llvtt commented 10 years ago

+1

tchap commented 10 years ago

:+1:

ghost commented 10 years ago

+1

gr2m commented 10 years ago

:+1:

gauteh commented 10 years ago

:+1: for gods sake.

thenbrent commented 10 years ago

:+1:

rGaillard commented 10 years ago

+1

aarana-ix commented 10 years ago

+1

gaillafr commented 10 years ago

+1

snowwlex commented 10 years ago

+1

ranjaykrishna commented 10 years ago

+1

ajbrown commented 10 years ago

:+1:

Aaronius commented 10 years ago

+1

fsaez-ix commented 10 years ago

+1

andrewrk commented 10 years ago

:camel:

seriallos commented 10 years ago

:thumbsup:

barts commented 10 years ago

+1

maxsnew commented 10 years ago

:+1:

dgbeck commented 10 years ago

+1

Zolmeister commented 10 years ago

+1

ViliusKraujutis commented 10 years ago

Had to close old PR and create new one with correct target. It's good, that it was noticed early and not much discussion happened.

tz commented 10 years ago

:+1:

franck-nadeau commented 10 years ago

+1

pkallos commented 10 years ago

+1

pdyraga commented 10 years ago

:+1:

garonsky commented 10 years ago

+1