Closed tjfontaine closed 7 years ago
Oh this is much needed :+1:
What's wrong with closing and opening a new pull request? You can still reference the previous one if the discussion is of any value.
@jzaefferer There's nothing wrong with it. It's simply inconvenient.
It's also very tedious, and having to open a second because the goal post has changed for a milestone seems inconvenient, especially since I can rebase the target multiple times but in the end all utility of the comparison is lost because it's not pointing to anything sane
I too would appreciate this feature.
It would also be handy if you could set the pull request target to a new branch. github could create a "pending branch" on upstream's repo. When the pull is merged, it creates - and immediately pushes to - the upstream branch.
:+1:
+1
+1
+1
+1
+1
+1
+1
:+1:
Also in favour. Just did a pull request to wrong branch and ended up with the longest diff.
:+1:
:+1:
:+1:
:+1: this would be a great improvement. I've sent an email to GitHub support, referencing to this issue.
+1
I received the following response from GitHub:
Thanks for your feedback about pull requests, Nic!
I've added your suggestions to our internal feature request list. We don't comment publicly about if or when we may implement a particular feature until it has shipped, however your feedback has definitely been recorded.
Let us know if you have any other suggestions.
Cheers, Ivan
I received the following response from GitHub:
That's their standard "we can't comment" reply. :smile:
+1
:+1:
+1
:+1:
+1
:+1:
:+1: for gods sake.
:+1:
+1
+1
+1
+1
+1
:+1:
+1
+1
:camel:
:thumbsup:
+1
:+1:
+1
+1
Had to close old PR and create new one with correct target. It's good, that it was noticed early and not much discussion happened.
:+1:
+1
+1
:+1:
+1
It can be necessary to pick a different target branch for a pull request if you accidentally select the wrong one, or perhaps you're asked to rebase the branch against a development branch vs a stable branch.