isaacs / github

Just a place to track issues and feature requests that I have for github
2.2k stars 129 forks source link

Gist comments and mentions don't trigger notifications #21

Closed max-mapper closed 5 years ago

max-mapper commented 11 years ago

this used to work.

to reproduce:

luk- commented 11 years ago

This

kastiglione commented 11 years ago

I asked support about this, and on May 31st they said:

Notifications for gist comments isn't implemented now, but it's something the team has discussed, so this could change in the future. We'll definitely announce this on our blog if it gets pushed out.

balupton commented 11 years ago

:+1: it is soooooooo infuriating, it is a common occurrence where I discover a very important comment or even a job offer that is a year old or so on a gist

balupton commented 11 years ago

If anyone has any 3rd party solutions to this, then do please post!

commonsguy commented 11 years ago

And, according to this gist, this is a fairly popular feature request/bug fix. What is the point of having comments if the developer of the gist will not hear them (short of manually monitoring the page)? After all, we cannot use existing tools for change detection, partially because the page always changes ("Created NNN days ago") and partially because robots.txt blocks monitoring of gists.

swrobel commented 10 years ago

:+1:

r-a-y commented 10 years ago

:+1:

eddieajau commented 10 years ago

:+1: - very annoying

BrainCrumbz commented 10 years ago

+1

pstadler commented 10 years ago

+1

X4 commented 10 years ago

:+1: I really need it too, but don't immediately send the notification and don't include the message in the notification! Every edit should increase the notification by 15minutes.

patcon commented 10 years ago

@X4 that sounds like i might be a separate issue request that's great in its own right..? re: delaying notifications using some known criteria.

Would it be cool to open another issue on that?

X4 commented 10 years ago

@patcon hmm, I believe that it's not required, because the changes would be both very simple and results in extending the function responsible for writing a notification flag that makes the notification icon on the top left shine. I assume GitHub uses some kind of asynchronous message passing system, so delaying a notification due to an edit under 15min would just require an update of the timestamp in the message queue. For efficiency reasons, I would not set it to a fixed time of 15minutes, but let it be larger, when required, so that more queued items can be updated at once. This would result in less updates.

patcon commented 10 years ago

Sorry, wasn't saying it wasn't simple, but just that it's not what the OP was asking about, and that it would definitely be useful for other things (as opposed to just gist comments) :)

mehulkar commented 10 years ago

:+1:

Mithgol commented 10 years ago

:+1:

mburgert commented 10 years ago

:thumbsup:

kramerc commented 10 years ago

For the interim, I made a script that send me emails about new comments left on my gists and I made it available at https://github.com/kramerc/gist_notifier.

headius commented 10 years ago

:+1:

narqo commented 10 years ago

:+1: — it would be great!

skuehn commented 10 years ago

:thumbsup:

eshilts commented 10 years ago

:thumbsup:

gep13 commented 10 years ago

:+1:

cdeszaq commented 10 years ago

:+1:

timyates commented 10 years ago

:+1:

balupton commented 10 years ago

@jookyboi could you perhaps please bring a comments listing and comments notifications into gistbox?

nanobeep commented 10 years ago

Oh man. Just discovered an important comment from 5 months ago on one of my gists. Hope they don't think I'm an asshole for not replying. Was never notified :/

Please help us not look like assholes :)

nicholashagen commented 10 years ago

+1

zoerooney commented 10 years ago

+1

juhoautio commented 10 years ago

:+1:

fthomas commented 10 years ago

:+1:

etorreborre commented 10 years ago

+1 (I actually missed @fthomas comments on my gist, see above)

andrewholt commented 10 years ago

+1

wmoxam commented 10 years ago

I was just bit by this. Please fix :+1:

BigglesZX commented 10 years ago

+1

dlo commented 10 years ago

I could've sworn that this used to work and thought I was crazy, but given the amount of activity on this post it seems I'm not the only one who misses this. @github please bring Gist email notifications back!

dnlserrano commented 10 years ago

:thumbsup:

jaredcacurak commented 10 years ago

:thumbsup:

aronwoost commented 10 years ago

👍

mgol commented 10 years ago

:+1: SO infuriating.

tannerhodges commented 10 years ago

+1

aaronwolen commented 10 years ago

+1

davidnormo commented 10 years ago

yes please, now, or sooner, thanks!

soumith commented 10 years ago

+1

mhulse commented 10 years ago

I filed this issue a while back as well. +1

konklone commented 10 years ago

:+1: so needed, so obvious

mrwweb commented 10 years ago

+1

rosenfeld commented 10 years ago

:+1:

vjoel commented 10 years ago

This is an absurd situation: a 'social' medium that doesn't let you know when someone is responding to you.

viktorklang commented 10 years ago

:+1: