search

isaacs / github

Just a place to track issues and feature requests that I have for github
2.21k stars 129 forks source link

comments on github files #226

Open AlexFrazer opened 10 years ago

AlexFrazer commented 10 years ago

I was looking at a project the other day. I noticed a pattern that I had not seen in official documentation, but had seen in other examples, so I was curious. It would have been great to leave a comment asking why he chose to do what he did, as I am sure he had a reason. gist.github.com offers a way to leave comments on a small file. I have found this very useful in several cases. I think it seems fitting that a more robust system would be implemented for large-scale projects.

I think the most ideal would be a way to leave comments on multiple lines by selecting the lines and clicking on a "comment" pop up. The comment, nonintrusively, could show up at the bottom of the page and selecting it would show you the lines it refers to. On top of that, it would be nice to leave comments on entire directories. In the repo I mentioned earlier, my question was about the app/static/js folder, and why he structured that area as he did

Thank you

Mithgol commented 10 years ago

Your issue is probably a duplicate of the already open issue #211, check it.