search

isaacs / github

Just a place to track issues and feature requests that I have for github
2.21k stars 129 forks source link

Allow commenting on non-pull-request code #284

Open dmugtasimov opened 10 years ago

dmugtasimov commented 10 years ago

When reading someone's code I need to ask an author why he/she code that way, not another or ask for clarfication of piece of code for better understanding or suggest an alternative solution for consideration without making pull request. There fore it would useful communication in the context of the code line, so please, allow commenting on any code in repository.

0xba1a commented 4 years ago

+1

kpeluso commented 4 years ago

+1

Here's a hacky, cumbersome, but viable workaround in the meantime:

  1. Click the link to view the merge request (as any non-code reviewer would)
  2. Click a line of code, comment, post comment (this can be done to any line of code)
  3. Click the ellipsis menu of your comment and "Copy link"
  4. Nav back to your code review and share those links to your comments
WilliamLQin commented 4 years ago

+1

oxygenecore commented 4 years ago

Would be nice to hear official comment on this :thinking:

jeffabailey commented 4 years ago

Would be nice to hear official comment on this 🤔

+1

Exr0n commented 4 years ago

EDIT: nevermind.

If you go to any commit, you can scroll to the bottom to add a comment: image or comment on lines of code directly: image

This is what I was looking for, at least. Glad they finally added it :)

dgw commented 4 years ago

@Exr0n That feature's existed for years. Commenting there is completely disconnected from any PR review.

Exr0n commented 4 years ago

Hm, I guess I never noticed it then. @dgw what feature did you have in mind? I thought this matched the description of the original comment for this issue: "allow commenting on any code in repository".

dgw commented 4 years ago

@Exr0n Most of us (I think) are looking for a solution to situations like the one I described here. That is, when we're reviewing PRs and need to add line notes or suggestions outside the context of the current patch.

muescha commented 4 years ago

If you go to any commit, you can scroll to the bottom to add a comment:

i have done some of this kind of comments in commits, but never get an answer - i am not sure if they really delivered to the code owner

oxygenecore commented 4 years ago

Ok, I've finally read the description to this repo. It's not anything official. Though, I could not find any official public bug repository for GitHub cloud. Does anyone know where were should post to have official answer?

HighCommander4 commented 4 years ago

Though, I could not find any official public bug repository for GitHub cloud.

I'm not aware of one. (If only they had a convenient platform where they could host their own bug tracker...)

muescha commented 4 years ago

@oxygenecore

jasonkhadka-kd commented 4 years ago

Still no update on this from GitHub. how can we tag them here?

muescha commented 4 years ago

@jasonkhadka-kd this is not a official github repo

chrisjsewell commented 4 years ago

If someone does this, can they post the reply/link here thanks. It would be nice to know that someone in GitHub is aware of this issue and the amount of upvotes it has here.

calculuschild commented 4 years ago

@muescha I have contacted them multiple times pointing to this repo. Never got a response. Maybe someone else will have better luck?

jason-koppel-avlino commented 4 years ago

+1

srozdilsky commented 4 years ago

+1 IMO, this is not just a feature request but a bug (missing basic functionality). I have always been frustrated by the lack of ability to do this in a github PR. I have never had an issue in other Peer Review platforms.

dabrahams commented 4 years ago

For what it's worth, there's a project called ReviewNB that supports this feature for Jupyter Notebooks in GitHub. If someone could figure out how to make that work for all files, it would solve this problem.

bw2 commented 4 years ago

+1

lupinitylabs commented 4 years ago

+1. I am surprised that this doesn't work in Github. Especially in a refactoring PR, there is no accurate way of pointing out to someone that they missed something.

okwme commented 4 years ago

+1

Androz2091 commented 3 years ago

I agree this would be really useful, and we should be able to make suggestions too. Someone sent me a PR, it was a complete rewrite of my NPM package in TypeScript and sometimes he forgot to add types and I'm not able to comment on these lines...

ToddBradley commented 3 years ago

It's now been 6 years and 3 months. Welcome to 2021, dear readers. As far as I can tell, there has been no progress in GitHub in this area.

chadm-sq commented 3 years ago

Not that you need more justification, but: In Go and some other languages, it is an error to import a module and not use it. A PR that removes the final use of a module, will cause problems up outside of the lines changed in the PR. A good commented PR has to be able to refer to those.

bhrutledge commented 3 years ago

I found this related post on the GitHub support forum: https://github.community/t/feature-request-review-comment-on-whole-file/135108. If folks know of other ones, could you add them here for reference?

bhrutledge commented 3 years ago

There's a Visual Studio Code extension that would facilitate this process: https://marketplace.visualstudio.com/items?itemName=vsls-contrib.codetour. There has been some discussion about adding it to the GitHub UI: https://github.com/microsoft/codetour/issues/10. The latest thinking is that GitHub CodeSpaces will be "the natural mechanism for enabling developers to replay a tour from GitHub." Someone has also created browser extensions for Chrome and Firefox to play tours in GitHub: https://github.com/doctolib/code-tours-github.

shadiramadan commented 3 years ago

How is this still an open issue 7 years later. @clarkbw

shadiramadan commented 3 years ago

I'm actually starting to regret my orgs switch to github.

SylvainTakerkart commented 3 years ago

+1 on the general feature request described in this issue!

chadm-sq commented 3 years ago

Unless you're fixing it or adding important non-personal details, please only just vote with the 👍🏻 and such at the top. Commentary noise is a good reason for the owner to close this bug report without addressing it. Small, discrete bug reports, without drama or entitled whining are best.

tribbloid commented 3 years ago

+1 and particularly important when combining with https://github.com/marketplace/actions/publish-unit-test-results

davidvincze commented 3 years ago

+1

ililic commented 3 years ago

How has this been open since 2014 lol 💩

Levi-Lesches commented 3 years ago

This isn't the official GitHub repo, https://github.com/github/feedback is. Open a discussion in the general feedback category (and link back to here) to get a response from GitHub staff.

ting-lan-wang commented 3 years ago

+1

chadm-sq commented 3 years ago

This is a private bug. No one from Github watching this or is using this to schedule work.

There are "+1" and smiley buttons, if you want to show support to things on Github, but adding comments like the previous sends email to a hundred people who don't care that much that you agree. If you want to indicate your support in a polite way, find the ":)" at the top.

Everyone else, if these notifications bother you too, please change your "participating" status to "ignored" at the top. https://github.com/isaacs/github/issues/284 I changed mine to avoid getting messages appended to this, and you can too.