isaacs / github

Just a place to track issues and feature requests that I have for github
2.2k stars 129 forks source link

Deal properly with uppercase .GIT file basenames on web editor like for lowercase .git #318

Open cirosantilli opened 9 years ago

cirosantilli commented 9 years ago

Either:

cirosantilli commented 9 years ago

They've replied (but I don't know who: it only says "GitHub Staff" this time).

OK, after https://github.com/blog/1938-vulnerability-announced-update-your-git-clients Git will blacklist uppercase .GIT from being tracked, so allowing .GIT is out. I though it was going to get fixed by just not checking things out.

Next, they've already improved the UI validation, but it is still different from lowercase .git:

stuartpb commented 9 years ago

Yeah, .GIT is a bad citizen in the cross-platform Git community, so I'm all in favor of blacklisting it (especially since that's what the mainline client does now by default). Agreed that GitHub should unify their solutions, though (not allowing the commit from the editor in realtime, the same way as .git).

Out of curiosity, if you bypass the .git prevention JS to post a file creation, does it give you the same error as .GIT currently does?