Batch notifications for pull requests

isaacs / github

Just a place to track issues and feature requests that I have for github

2.21k stars 129 forks source link

Batch notifications for pull requests #340

Open jantman opened 9 years ago

jantman commented 9 years ago

If a large PR is submitted and someone comments on 20 different lines, everyone watching that repo gets 20 emails about comments. There should be a way to batch these up - i.e. a button that allows me to start a "review session", make as many comments as I want, and then "submit" my session - sending all those comments as one batch.

cirosantilli commented 9 years ago

I would add the word "notification" to the title instead of update.

nevir commented 9 years ago

This is more than just wanting batched notifications, I think. Having a set of comments come in as a batch is a handy workflow:

The reviewer can build up a set of comments (drafts).
Once they are happy with their comments, they publish them; email is sent out at this point, and the comments are made visible.
It also serves as an explicit "ok, I'm done reviewing for now - now it's your turn to respond"
Similarly the pull request author can (ideally) respond to comments in batch.

lotyrin commented 8 years ago

Definitely would like batching on send side for reviews, but clustering+digest on receive side is critical.

troy-rudolph commented 8 years ago

Even if it just waited 10 mins to allow more comments to be added and then emailed, it would be better.

salsanchez commented 8 years ago

👍

benmeuer commented 8 years ago

:+1:

mattodd commented 7 years ago

Yes, would love to have this for Open Source Malaria, and I'm sure lots of other groups would welcome it.

chamini2 commented 7 years ago

This is resolved with reviews, right?

hopeseekr commented 6 years ago

I received 6,532 emails from GitHub.com from 17 Sep 2017 and 5 Feb 2018 (141 days).

That's *forty-six (46.33) emails a day!

Except, very few came in during the weekends. According to The Business Days Calculator, that's 95 days.

For the last 5 months, I've been receiving close to 69 (68.76) GitHub emails every day!

It's intolerable. Almost all of the emails are from notifications of commits to my ~15 co-workers' forks of the main repository.

JohannesMP commented 6 years ago

Please add an option on a repo's Watch settings to send daily/weekly digest emails for notifications. This should include Issues, pull requests, etc.

KopfKrieg commented 5 years ago

Any update on this? I need to get notifications for a lot of repos but I don't have to get a separate e-mail for every single one. Having a digest/summary setting for notifications woudl be really cool. And it would also reduce stress a lot here.

marc-hb commented 5 years ago

This is resolved with reviews, right?

Very partially. github reviews are just the start of the review conversations, then it's back to one email per comment unless I missed something. If every comment in every situation could always be made part of a larger github review then yes, that would help a lot.

marc-hb commented 5 years ago

Now I wonder whether the impossibility to batch reviews again isn't caused by the use of force-pushes... see this "Outdated" label?

As opposed to force pushes, "fixup" commits and final squash seems to be the model github focuses on. I wish the documentation made that point louder and clearer because it's not how most other git reviews work.