Generate comment previews client-side

isaacs / github

Just a place to track issues and feature requests that I have for github

2.21k stars 129 forks source link

Generate comment previews client-side #433

Open jacksonrayhamilton opened 9 years ago

jacksonrayhamilton commented 9 years ago

The network latency on creating comment previews is annoying. Sometimes (on my crappy connection) the Preview tab will just hang on "Loading preview...". Can't the previews be generated client-side? If so, please do that.

This is probably also a barrier to implementing https://github.com/isaacs/github/issues/388.

cirosantilli commented 9 years ago

+1.

GitLab went Accepting MR on 388: http://feedback.gitlab.com/forums/176466-general/suggestions/5799911-preview-as-you-type-for-markdown-blob-file-edit but no action so far.

Note: this hard to do precisely: the only way is to port their current Ruby Md engine to Js and keep both in perfect sync :-)

Gaelan commented 9 years ago

@cirosantilli They could use Opal.

cirosantilli commented 9 years ago

@Gaelan that is a great idea! Someone should try converting the Md engine with it so see if it works.