search

isaacs / github

Just a place to track issues and feature requests that I have for github
2.21k stars 129 forks source link

Include SHA1s of original commits when pull request is squash+merged. #688

Open wkoszek opened 8 years ago

wkoszek commented 8 years ago

Squash and merge works OK in GitHub, and already includes the messages of original commits.

It'd be good if along comments it also included SHA1s of them, so that I could see individual changes.

cirosantilli commented 8 years ago

Do you mean to see individual commit changes on the web UI before the OP possibly removes the branch?

ePaul commented 8 years ago

When a branch is merged by squashing, basically the original commits are not in the history anymore. This is the point of squashing them. So the SHA1s would point to nowhere.

aensley commented 8 years ago

As @ePaul mentioned, this goes against the design purpose for squashing. If you want the original commits, don't use squash+merge. It's a trade-off either way.

aspiers commented 7 years ago

Yeah, I don't think this request makes sense.