search

isaacs / github

Just a place to track issues and feature requests that I have for github
2.21k stars 129 forks source link

Mark pull request as depending on another #959

Open OliverJAsh opened 7 years ago

OliverJAsh commented 7 years ago

Quite often I find myself raising a pull request that contains another within it as a dependency. I want the diff to be exclusive of the dependency pull request’s changes, otherwise my colleagues end up reviewing more than they need to, or worse, the same changes twice (in both pull requests).

To workaround this, I usually set the base of my pull request to the dependency pull request, however this has caveats:

I would like to see some UI in GitHub to make this workflow first class:

jd commented 3 years ago

For what it's worth, it's now also a feature in Mergify. When using the merge action, which enables automatic merge, it'll respect Depends-On headers.

ejoffe commented 3 years ago

Also suffering from these same stacked pull request headaches, I wrote a client side tool that manages pull request stacks for you automagically. If you like the gerrit style workflow, checkout git spr https://github.com/ejoffe/spr. For me it has brought back sanity to managing pull requests on github. I'd love to get your feedback.

oprogramador commented 3 years ago

@OliverJAsh

Are you going to clone this proposal to https://github.com/github/feedback/discussions ?

aspiers commented 3 years ago

@oprogramador commented on July 6, 2021 3:52 AM:

@OliverJAsh

Are you going to clone this proposal to https://github.com/github/feedback/discussions ?

This was already done, so please don't submit a duplicate - thanks ;-)

oprogramador commented 3 years ago

@oprogramador commented on July 6, 2021 3:52 AM:

@OliverJAsh Are you going to clone this proposal to https://github.com/github/feedback/discussions ?

This was already done, so please don't submit a duplicate - thanks ;-)

Thanks. Sorry, I submitted this as I was able to find neither Mark pull request as depending on another nor Mark pull request as depending nor depending on another as the new title is Make Child Pull Requests Dependent on Parent Pull Requests. I wasn't able to find feedback/ in this issue discussion either.

aspiers commented 3 years ago

@oprogramador commented on July 8, 2021 7:51 PM:

Sorry, I submitted this as I was able to find neither Mark pull request as depending on another nor Mark pull request as depending nor depending on another as the new title is Make Child Pull Requests Dependent on Parent Pull Requests. I wasn't able to find feedback/ in this issue discussion either.

No worries. But that exactly proves the importance of GitHub doing this migration properly, and quickly. Please can you link to the discussion you filed, and also close it with an explanation which links to https://github.com/github/feedback/discussions/4477 and to here?

oprogramador commented 3 years ago

I haven't opened any discussion related to this issue.

aspiers commented 3 years ago

Ah I see, by "I submitted this" I guess you meant "I wrote the above comment" rather than "I submitted a new discussion topic". I misunderstood it as meaning the latter.

oprogramador commented 3 years ago

Ah I see, by "I submitted this" I guess you meant "I wrote the above comment" rather than "I submitted a new discussion topic". I misunderstood it as meaning the latter.

Yes, I meant posting a comment.

webzorg commented 3 years ago

It would be stupidly easy to implement this feature but yet this issue is open for a decade. 2021!

Levi-Lesches commented 3 years ago

@webzorg There are a few custom solutions:

The GitHub team can't possibly be expected to implement every possible feature that everyone wants. That's why they gave the open source community access to GitHub APIs, GitHub Actions, and GitHub Apps. If there are community-run solutions out there, I encourage you to use them. And if they don't exist, make them!

gregsdennis commented 3 years ago

... Dependency-check from me

Levi-Lesches commented 3 years ago

Thanks, added to the list. I'll use that list if similar discussions arise.

EDIT: Here's the discussion on the official GitHub feedback repo: https://github.com/github/feedback/discussions/4477#discussioncomment-1039627