isaacs / nave

Virtual Environments for Node
ISC License
1.61k stars 137 forks source link

Fix: arch detection on darwin #88

Closed joeybaker closed 5 years ago

joeybaker commented 7 years ago

I'm not sure what changed/if this is just my machine, but for me:

uname -a
Darwin xxxxx 16.4.0 Darwin Kernel Version 16.4.0: Thu Dec 22 22:53:21 PST 2016; root:xnu-3789.41.3~3/RELEASE_X86_64 x86_64 i386 MacBookPro11,3 Darwin

Which means this case statement would set $arch to x86, which isn't valid for macOS downloads which are x64. This results in a 404 error, and nave fails to install anything. Switching the order produces the correct results for me. But I haven't tested on other architectures, so I'm not sure what the implications here.

isaacs commented 5 years ago

c902f4c v2.3.0