search

isaacs / node-graceful-fs

fs with incremental backoff on EMFILE
ISC License
1.27k stars 148 forks source link

Tests for gfs global patch never actually tests local gfs #163

Closed ZauberNerd closed 5 years ago

ZauberNerd commented 5 years ago

I noticed, that node-tap has a dependency to write-file-atomic which in turn depends on graceful-fs.

This is a problem when executing the test suite with the environment variable TEST_GRACEFUL_FS_GLOBAL_PATCH set, because then the graceful-fs from node_modules will already alter the fs module and therefore the graceful-fs implementation in this repository, that we actually want to test, will never be tested.

This blocks: https://github.com/isaacs/node-graceful-fs/pull/162

isaacs commented 5 years ago

write-file-atomic v3 will not include graceful-fs as a dependency, which should address this.