search

isaacs / node-graceful-fs

fs with incremental backoff on EMFILE
ISC License
1.27k stars 148 forks source link

pnpm silently fails with 0 exit code after update to graceful-fs 4.2.5 #203

Closed zkochan closed 3 years ago

zkochan commented 3 years ago

I don't know how this is possible but after graceful-fs has been updated to 4.2.5, pnpm silently fails during installation. There is no error printed and the exit code is 0. Downgrading graceful-fs fixes the issue.

GiladShoham commented 3 years ago

Hi, I'm the author of bit I have this issue too. Since version 4.2.5 our app is completely broken in production. The process exists with code 0 just in the middle of the installation process.

Please help us out here with a new patch version.

Thanks in advanced

FeelyChau commented 3 years ago

@zkochan @GiladShoham copyFile will miss the callback function if pass a flag, you can have a look at this: #202 pnpm use it here: https://github.com/pnpm/pnpm/blob/main/packages/package-store/src/storeController/createImportPackage.ts#L102

coreyfarrell commented 3 years ago

4.2.6 has been released, should fix this issue.