Open kt3k opened 3 years ago
fs-extra
is broken and cannot be bundled because of this.
@isaacs Would be great if you could take a look at this. As per https://nodejs.org/api/deprecations.html#DEP0008
The constants module is deprecated. When requiring access to constants relevant to specific Node.js builtin modules, developers should instead refer to the constants property exposed by the relevant module. For instance, require('fs').constants and require('os').constants.
constants
module has been deprecated since v6.3.0 (ref: https://nodejs.org/api/deprecations.html#DEP0008 ). This PR updates the use ofconstants
tofs.constants
.BTW
fs.constants
doesn't inherit from Object.prototype (ref: https://github.com/nodejs/node/pull/10458 ), so I updatedconstants.hasOwnProperty('O_SYMLINK')
toconstants.O_SYMLINK !== undefined
. (This change was discussed in node.js repository https://github.com/nodejs/node/pull/10458#discussion_r93860956 )