Closed mbargiel closed 3 years ago
I don't understand the CI failures. The Npm run test
step has identical outputs between failed and successful builds, unless it's failing because it takes a bit longer on some test builds. ⁉️
EDIT: Ah, I see it's not an abnormal situation. 😌
The
copyFile
wrapper introduced in #199 does not follow the same pattern as the other wrappers, and enqueued the wrappedcopyFile
rather than the wrapper function, which means that a subsequentEMFILE
orENFILE
error occurring when retrying thecopyFile
would fail and bubble theEMFILE
orENFILE
to the calling code rather than enqueue again. This fix applies the same pattern by introducinggo$copyFile
and enqueueing it rather thanfs$copyFile
.Fixes #208.
All tests pass and coverage goes up a bit (probably just because the new lines of test code are covered). I couldn't find tests that validate the
EMFILE
retry logic for thefs
function wrappers (at least not forcopyFile
).