search

isaacs / node-graceful-fs

fs with incremental backoff on EMFILE
ISC License
1.27k stars 148 forks source link

fix(stat): support throwIfNoEntry for `statSync` #220

Closed bluelovers closed 2 years ago

songhobby commented 2 years ago

Can someone merge this? This bug breaks lots of things depending on it

peteromano commented 2 years ago

@bluelovers Nuxt3 development and the whole internet and world is broken until this is merged.

See: https://github.com/nuxt/nuxt.js/issues/13155

Priority level 5000.

image

songhobby commented 2 years ago

@bluelovers Nuxt3 development and the whole internet and world is broken until this is merged.

I come from Next.js world, same thing and very accurately said, the world is broken until this is MERGED!

isaacs commented 2 years ago

Landed and published. You can all stop posting memes and blowing up my notifications on social media now.

Listen. I'm sensitive to the frustration that you feel when something breaks because of a change that some part of the system didn't know to accommodate. Especially when it's not something you can fix easily.

That said, if a piece of code just sitting there not changing can break the whole internet, then I don't know, maybe it should be broken. Did you consider that this is a bug in the thing that calls statSync({ throwIfNoEntry: false })? That perhaps it shouldn't be used with graceful-fs? Or maybe that the thing using graceful-fs shouldn't be using it in the way it does? Or as your app grows into a rube goldberg machine (as every piece of software eventually does), maybe it just doesn't work when you bump to Node.js version higher than 14.17 or using it with whatever updates to whatever things led to it calling statSync({throwIfNoEntry: false}) through graceful-fs.

Or you could have just, idk, forked this library and maintained it more regularly. I don't use it much anymore, and frankly, the safest thing to do is just not touch it.

Take a breath. Touch some grass. Be nice to people. It's going to be OK. This bug is not the thing breaking the world, I fucking promise you that.