search

isaacs / node-tar

tar for node
ISC License
837 stars 183 forks source link

chore: use a local instead of remote file for test #337

Closed lukekarrys closed 1 year ago

lukekarrys commented 1 year ago

I was able to replicate the same behavior from #332 by piping a readable stream with a highWaterMark of 1 to extract. I confirmed this test still failed without the fixes from #332 and now passes.

webark commented 1 year ago

nice! that's good to know.

lukekarrys commented 1 year ago

@webark I learned it while making this PR 😄 You're original PR was very helpful and I was fine to leave it as an https request. But I decided to investigate a little since I'd be getting notifications for a flaky test and stumbled upon this fix.

wraithgar commented 1 year ago

it's probably good to still have a test that makes sure this works with a stream sent directly from http/https. I know nock can return streams.

lukekarrys commented 1 year ago

Force pushed a new commit that adds another test mocked with nock.